Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings for TLS and mail server authentication to EmailService #933

Conversation

matsbov
Copy link
Contributor

@matsbov matsbov commented Dec 12, 2024

This PR adds the possibility to use TLS and mail server authentication with the EmailService (used for notifications about downloaded records).

Using these options may look like this in the config file:

mail.smtp.host=mail.example.com
mail.smtp.port=587
mail.smtp.starttls.enable=true
[email protected]
mail.smtp.password=abc123

@vjrj
Copy link
Contributor

vjrj commented Dec 12, 2024

What I do to avoid this is to use localhost and configure a postfix with the real configuration (with ssl, etc).

I configure all the servers that use mail also via ansible:
https://github.com/AtlasOfLivingAustralia/documentation/wiki/Postfix-configuration

@matsbov
Copy link
Contributor Author

matsbov commented Dec 13, 2024

Yes, we also had a separate in-between postfix. However, all other services we have were already talking directly to the real mailserver so we could now get rid of the postifx. Personally I prefer it this way with one component less.

@vjrj
Copy link
Contributor

vjrj commented Dec 13, 2024

Uppps, for a moment I forget that you are using docker. Sorry.

@nickdos nickdos requested a review from adam-collins January 14, 2025 22:59
Copy link
Contributor

@adam-collins adam-collins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@adam-collins adam-collins merged commit 9dee0e5 into AtlasOfLivingAustralia:develop Jan 14, 2025
1 check passed
@matsbov matsbov deleted the upstream-emailservice branch January 15, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants